Skip to content

Conversation

@sttk
Copy link
Owner

@sttk sttk commented Aug 22, 2025

T/O.

@sttk sttk requested a review from Copilot August 22, 2025 04:11

This comment was marked as outdated.

@sttk sttk force-pushed the add_a_test_case_of_constructor_using_connection_info branch from 8c20c03 to 8297838 Compare August 22, 2025 04:15
@sttk sttk requested a review from Copilot August 22, 2025 04:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new test case to verify that the Redis data source constructor works correctly when initialized with connection info instead of a Redis URI string.

  • Adds a new test function ok_by_connection_info() that tests Redis connection using redis::ConnectionInfo struct
  • Renames the existing test from ok() to ok_by_redis_uri() for better clarity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sttk sttk changed the title Add a test case of constructor using connection info test: Add a test case for RedisDataSrc constructor using redis::ConnectionInfo Aug 22, 2025
@sttk sttk changed the title test: Add a test case for RedisDataSrc constructor using redis::ConnectionInfo test: added a test case for RedisDataSrc constructor using redis::ConnectionInfo Aug 22, 2025
@sttk sttk merged commit dee612f into main Aug 22, 2025
5 of 6 checks passed
@sttk sttk deleted the add_a_test_case_of_constructor_using_connection_info branch August 22, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants